[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] cleanup of loging definitions



On Thu, Nov 06, 2008 at 02:16:52PM +0100, Daniel Veillard wrote:
>   Currently the debugFlag switch, the VIR_DEBUG, DEBUG and DEBUG0
> macros were scattered in various places, duplicated once (or twice)
> per generated binaries. This patch moves everything in one virtlog.h
> header, one virtlog.c file and set up the makefiles so that the
> various binaries refers to the same bits.
>   That's a cleanup with no functional change to prepare the real
> loging APIs, patch and the 2 new files attached,

ACK, this seems like a good idea considering we'll have more logging
stuff in the future. I'd prefer to drop the 'virt' prefix though and
just call it 'logging.c' or 'log.c'

Perhaps we should have a virLogInitialize() method todo the stuff
like getenv("LIBVIRT_DEBUG") that's currently in virInitialize().
eg, just make virInitialize() call virLogInitialize() for setup

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]