[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: OpenVZ bridge support



Sorry for delay.

Big thanks for docs!

This is an update of the patch
http://www.redhat.com/archives/libvir-list/2008-October/msg00326.html

To enable bridge support in the OpenVZ driver. As well as the fixes
suggested last time, it includes an initial bit of HTML doc for the
openvz driver, covering example XML, and the bridge configuration
requirements

Daniel


+
+    while(1) {
+        if (openvz_readline(fd, line, sizeof(line)) <= 0)
+            break;
+
+        if (!STRPREFIX(line, param) &&
+            line[strlen(param)] == '=') {
+            if (safewrite(temp_fd, line, strlen(line)) !=
+                strlen(line))
+                goto error;
+        }
+    }
+

this condition make container config completely broken.
as the patch is already commited, here is fix.

diff -u -r1.49 openvz_conf.c
--- openvz_conf.c       12 Nov 2008 16:35:47 -0000      1.49
+++ openvz_conf.c       14 Nov 2008 16:14:24 -0000
@@ -484,8 +484,7 @@
         if (openvz_readline(fd, line, sizeof(line)) <= 0)
             break;

-        if (!STRPREFIX(line, param) &&
-            line[strlen(param)] == '=') {
+        if (!(STRPREFIX(line, param) && line[strlen(param)] == '=')) {
             if (safewrite(temp_fd, line, strlen(line)) !=
                 strlen(line))
                 goto error;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]