Re: [libvirt] --with-xen=foo

[Ben Guthro <bguthro virtualiron com>]

I tried this...didn't seem to help:



diff --git a/src/Makefile.am b/src/Makefile.am
index 3520130..6a38200 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -279,7 +279,7 @@ libvirt_la_LDFLAGS = -Wl,--version-script=$(srcdir)/libvirt_sym.version \
                     $(COVERAGE_CFLAGS:-f%=-Wc,-f%) \
                     $(LIBXML_LIBS) $(SELINUX_LIBS) \
                    @CYGWIN_EXTRA_LDFLAGS@ @MINGW_EXTRA_LDFLAGS@
-libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) -DIN_LIBVIRT
+libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) $(XEN_CFLAGS) -DIN_LIBVIRT
 libvirt_la_DEPENDENCIES = $(libvirt_la_LIBADD) $(srcdir)/libvirt_sym.version

 # Create an automake "convenience library" version of libvirt_la,



Daniel P. Berrange wrote on 11/20/2008 10:50 AM:
> On Thu, Nov 20, 2008 at 10:46:25AM -0500, Ben Guthro wrote:
>> I did a git bisect, and as predicted, the culprit seems to be
>>
>> aac3e1ab15645f1ff491b140ddb249b01397bebd is first bad commit
>> commit aac3e1ab15645f1ff491b140ddb249b01397bebd             
>> Author: Daniel P. Berrange <berrange redhat com>            
>> Date:   Mon Nov 17 10:43:30 2008 +0000                      
>>
>>     Build drivers as libtool convenience libs
>>
>>
>> Once again, I am faced with my ignorance of how automake 
>> magic works.
>>
>> It looks to me like XEN_CFLAGS is set properly...but clearly 
>> they are not being passed on while compiling stats_linux.c
> 
> Argggh. I didn't notice that stats_linux.c had Xen specific
> code in it :-(  When I did the refactoring, it changed so
> that XEN_CFLAGS/LDFLAGS is only used for the Xen driver code
> 
> As a quick workaround, edit the line for
> 
>   libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) -DIN_LIBVIRT
> 
> to add  $(XEN_CFLAGS)
> 
> 
> Meanwhile I'll figure out  why stats_linux.c needs Xen, and move the Xen
> specific bit into the Xen driver.
> 
> Daniel