Re: [libvirt] [PATCH] Reboot support for QEMU/KVM

[Eduardo Habkost <ehabkost redhat com>]

On Tue, Oct 07, 2008 at 09:58:47PM +0100, Daniel P. Berrange wrote:
> On Tue, Oct 07, 2008 at 05:55:37PM -0300, Eduardo Habkost wrote:
> > This patch implements reboot support on qemu_driver.
> > 
> > It is so simple that I am wondering if there is some problem I am missing,
> > that would be the reason it wasn't implemented yet. I hope not.  :)
> 
> The reboot command is intended todo a controlled shutdown, followed by
> warm restart. Doesn't the system_reset command do an immediate warm 
> reboot ?

Yes, it does. Sorry, I should have read the virDomainReboot() description
on the API documentation first.

> 
> I think we needs to happen is that we invoke the 'system_shutdown'
> command, and when we detect the VM has quit, then manually start
> it again. This is technically a cold reboot, but its close enough

It would be better than not supporting reboot at all.

Maybe libvirt itself could fallback to this if reboot is not implemented?
If not, maybe the UIs using libvirt could do that?

-- 
Eduardo