[libvirt] [PATCH 4/5]: Make dumpXML more idempotent with defineXML

[Daniel P. Berrange]

On Tue, Oct 21, 2008 at 03:57:13PM +0200, Chris Lalancette wrote:
> Currently, you can define a logical storage pool with something like the following:
> 
> <pool type='logical'>
> 	<source>
> 		<name>MyVG</name>
> 		<device name='/dev/sdb'/>
> ...
> 
> However, dumping out the XML for this same storage pool (with, say, virsh
> pool-dumpxml), gives:
> 
> <pool type='logical'>
> 	<source>
> 		<name>MyVG</name>
> 		<device name='/dev/sdb'>
> 		</device>
> 
> 
> To make this more idempotent, do the <device name='/dev/sdb'/> form by default,
> and only do the <device>...</device> form if .nfreeExtent is defined for the
> storage pool.

ACK


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|