[libvirt] Re: [PATCH 11/12] Domain Events - test harness

[Daniel P. Berrange]

On Tue, Oct 21, 2008 at 03:20:19PM -0400, Ben Guthro wrote:
> [PATCH 11/12] Domain Events - test harness
> Test app, and infrastructure changes for an example dir

ACK.

> diff --git a/examples/domain-events/events-c/Makefile.am b/examples/domain-events/events-c/Makefile.am
> new file mode 100644
> index 0000000..3c63ca3
> --- /dev/null
> +++ b/examples/domain-events/events-c/Makefile.am
> @@ -0,0 +1,5 @@
> +INCLUDES = -I at top_srcdir@/include
> +bin_PROGRAMS = event-test

Quick automake black-magic tip...

Since we don't want the examples installed into /usr/bin, we can
simply replace

   bin_PROGRAMS = event-test

with

  noisnt_PROGRAMS = event-test

> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index cfd4a66..450d907 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -249,6 +249,9 @@ rm -rf $RPM_BUILD_ROOT%{_datadir}/doc/libvirt-python-%{version}
>  rm -rf $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu.conf
>  %endif
>  
> +# We don't want examples in the built rpm
> +rm -f $RPM_BUILD_ROOT%{_bindir}/event-test


Use of 'noinst_PROGRAMS' will avoid the need for this

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|