Re: [libvirt] [PATCH] Don't list capabilities entries if emulators can't be accessed

[Daniel Veillard <veillard redhat com>]

On Mon, Aug 25, 2008 at 01:16:39PM -0400, Cole Robinson wrote:
> Daniel P. Berrange wrote:
> > This isn't right - this means that if KVM is installed, but QEMU is
> > not installed you won't get any capabilities.
> > 
> > Basically we need todo all the access() checks for QEMU, KVM, /dev/kvm
> > up-front. And then generated the capabilites if either QEMU or KVM is
> > available.
> > 
> 
> Okay, I think this patch solves the issues. We check upfront
> for the base emulator and potential kvm emulators (qemu-kvm,
> and /usr/bin/kvm for ubuntu/upstream .spec). If nothing is
> found, just return. If only the base emulator is found, skip
> kvm even if /dev/kvm exists. If only kvm bin is found, add
> the base emulator capabilities only if emulator and host arch
> matches.

  That looks fine, applied and commited to CVS,

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/