Re: [libvirt] [PATCH] Fix vnc port determining for xend

[Cole Robinson <crobinso redhat com>]

Daniel P. Berrange wrote:
> On Thu, Sep 04, 2008 at 07:51:51AM +0200, Daniel Veillard wrote:
>   
>> On Thu, Aug 28, 2008 at 04:48:06PM -0400, Cole Robinson wrote:
>>     
>>> Current libvirt checks xenstore for a xen guests
>>> fixed vnc port on xend > 3.0.3. At least on f8
>>> though, hvm guests don't store the vnc port in
>>> xenstore, it is stored in the sexpr.
>>>
>>> Patch fixes the logic to look in the sexpr if
>>> the xenstore lookup appears to fail. This fixes
>>> setting static vnc ports for f8 xen hvm guests.
>>>       
>>   Sounds fine to me though I winder if it's not better
>> to check on the given SExpr first and then do a Xenstore
>> lookup only if needed. Seems to me a more generally coherent
>> approach, any expected drawback to this ?
>>     
>
> Historically XenD only ever put the VNC port in xenstore. Including it
> in the SEXPR is something new in 3.2.0 IIRC. 
>
> Daniel
>   
Actually I'm pretty sure this has been breaking static
vnc port since F8. So I'm not sure when this took effect
but if you give it a shot on F8 you'll see xm list --long
shows 'vncdisplay'.

Thanks,
Cole