Re: [libvirt] [PATCH] Fix segfault if no qemu emulator passed

[Cole Robinson <crobinso redhat com>]

Daniel P. Berrange wrote:
> On Mon, Sep 08, 2008 at 11:10:17PM -0400, Cole Robinson wrote:
>> There is unfortunately a pretty prevalent
>> segfault in the latest libvirt. If a qemu
>> domain is defined without an emulator
>> specified, libvirtd crashes.
>>
>> This is doubly unfortunate since current
>> virtinst generates an emulator-less config
>> for all qemu and kvm guests (I'm about to fix
>> this upstream though).
> 
> #%(*&#@(%   Damn. This is worthy of a brown paper bag release for libvirt
> to fix this shockingly bad bug.
> 

If we are going to do this I'd really like to get the
2 pending max vcpu patches committed, since it's a
big issue that we largely disallow smp kvm guests
at this moment.

>> diff --git a/src/qemu_conf.c b/src/qemu_conf.c
>> index d742c32..23ef050 100644
>> --- a/src/qemu_conf.c
>> +++ b/src/qemu_conf.c
>> @@ -790,7 +790,7 @@ int qemudBuildCommandLine(virConnectPtr conn,
>>      if (!emulator)
>>          return -1;
>>  
>> -    ADD_ARG_LIT(vm->def->emulator);
>> +    ADD_ARG_LIT(emulator);
>>      ADD_ARG_LIT("-S");
>>      ADD_ARG_LIT("-M");
>>      ADD_ARG_LIT(vm->def->os.machine);
> 
> ACK
> 
> Daniel

Thanks, I've committed this.

- Cole