Re: [libvirt] [PATCH] openvz: swap <source bridge=...> with <target dev=...>

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Sep 29, 2008 at 04:11:39PM +0400, Evgeniy Sokolov wrote:
> >2008/9/29 Evgeniy V. Sokolov <evg parallels com <mailto:evg parallels com>>
> >
> >
> >
> >               This behaviour contradicts with description found in docs
> >        (in which
> >               <source> tag specify interface in host, not in
> >        container). I think,
> >               the previous bridge must be specified as
> >                 <interface type='bridge'>
> >                   <mac address='00:16:3e:34:21:9e'/>
> >               -     <source bridge='eth10'/>
> >               +     <target dev='eth10'/>
> >                 </interface>
> >
> >           You are right. It is bug.
> >
> >        Well, here is the patch, that fixes that behaviour.
> >
> >
> >    Your patch is half of fix. It require to fix openvzReadNetworkConf() in
> >    openvz_conf.c.
> >
> > 
> >Here is a new one. Check it, please.
> 
> Patch looks good.
> But currently it will work strange because of all drivers (except 
> OpenVZ) in libvirt require specified <source bridge=""/> - it is generic.
> With patch you need to specify both
> <source bridge='eth10'/> - to satisfy common requirements
> <target dev='eth10'/> - to create network

That is not right. The <target> element *must* be optional when creating
a new domain. If omitted, the driver must generated a suitable target
dev according to its desired naming scheme. Only the <source> element
can be compulsory


Daniel.
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|