Re: [libvirt] [PATCH 1/1] Add SCSI pool support.

["Daniel P. Berrange" <berrange redhat com>]

On Wed, Apr 01, 2009 at 10:21:29AM -0400, Dave Allan wrote:
> Daniel Veillard wrote:
> >On Tue, Mar 31, 2009 at 05:49:47PM -0400, Dave Allan wrote:
> >>Dave Allan wrote:
> >>Attached is what I think is a final version of the scsi host pool code.  
> >>It's the set of patches we've been discussing rolled up into a single  
> >>patch, so it should look ok, but let me know if you have additional  
> >>comments.  I allowed both disk and rom and took out the XML enhancement  
> >>for device type.
> >>
> >>Dave
> >
> >  Patch looks fine to me, but I admit I didn't tested it
> 
> Can anybody volunteer to try it out?  (Dan has been shouldering the 
> entire burden so far.)  I've done a fair amount of testing over the 
> course of writing it, but at least one other person should try it out 
> before we commit it.  In particular, I haven't tried it with media in a 
> CD or DVD drive (my devel system is remote), so I don't know if a volume 
> actually gets created properly.  All the debug output is correct, so I 
> am reasonably confident, but it should be run once before committing. 
> I'm happy to advise on that effort.

I already tested that scenario and it worked fine !

I'm planning to commit this later today...


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|