[libvirt] [PATCH 1/1] Support for RDP

[Pritesh Kothari]

On Thursday 23 April 2009 14:47:17 Daniel P. Berrange wrote:
> On Thu, Apr 23, 2009 at 02:41:25PM +0200, Pritesh Kothari wrote:
> > Hi Daniel,
> >
> > > We don't currently have any explicit representation of a video card
> > > device. The <graphics> tag is really representing the host I/O
> > > layer, covering video, mouse, keyboard (and potentially audio
> > > too).
> >
> > I didn't get you here? i mean there is a seperate virDomainSoundDefPtr,
> > virDomainInputDefPtr, etc?
>
> I mean in terms of how this is exposed to an end user.
>
> VNC provides interaction for video, keyboard & mouse.
>
> SDL provides interaction for video, keyboard, mouse & audio
>
> RDP is similar.
>
>
> There are still the explict config sections for how video,
> mouse, sounds, etc are exposed to the guest OS.
>
> > > I think we need to add an explicit tag to represent video devices
> > > real soon. At very least we need to be able to indicate the type
> > > of video card - QEMU supports 4 already vga, cirrus, vmwarevga
> > > and xenfb. We probably also need to be able to indicate whether
> > > a video card supports multiple monitors / outputs, and the amont
> > > of Video RAM, etc.
> > >
> > > One random idea would be to add
> > >
> > >    <video>
> > >       <model type='cirrus' ram='500'/>
> > >    </video>
> >
> > does it means the graphics tag is no more and is replaced with video tag?
> > or video tag is added in addition to graphics tag?
>
> We'd have both - the <video> tag explicitly for things related
> to the video adapter device.  The <graphics> tag for the host
> side I/O layer config, be it VNC, RDP or SDL.

ok.

>
> > in any case how about adding "multihead" and "3Daccel" to it and renaming
> > ram to vram, something like this:
> >
> >     <video>
> >        <model type='cirrus' vram='500' multihead='2' 3Daccel='yes'/>
> >     </video>
>
> Sure, vram seems fine. I think i'd call multihead 'monitors' or 'heads'.
>

heads would do, but as DV said what about geometry and relative positioning? 

> Isn't 3D support implied by the type of graphics card emulated ?
> eg cirrus is a 2d only card, so it seems like 3Daccel is redundant.
> Similarly if the graphics model were a 3d card.

true. no need for that.

Regards,
Pritesh