[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fix soem missing directories and ownership in spec file



On Tue, Apr 28, 2009 at 11:34:38AM +0200, Daniel Veillard wrote:
>   The spec file in CVs was missing the creation fo some directories
> and forgot to take ownership of the cache subdir used for memory dumps
> with QEmu/KVM

> @@ -305,6 +305,13 @@
>  rm -f $RPM_BUILD_ROOT%{_libdir}/*.a
>  rm -f $RPM_BUILD_ROOT%{_libdir}/python*/site-packages/*.la
>  rm -f $RPM_BUILD_ROOT%{_libdir}/python*/site-packages/*.a
> +install -d -m 0755 $RPM_BUILD_ROOT%{_localstatedir}/run/libvirt/
> +# Default dir for disk images
> +install -d -m 0755 $RPM_BUILD_ROOT%{_localstatedir}/lib/libvirt/images/
> +# Default dir for kernel+initrd images
> +install -d -m 0755 $RPM_BUILD_ROOT%{_localstatedir}/lib/libvirt/boot/
> +# used for virDomainMemoryPeek
> +install -d -m 0700 $RPM_BUILD_ROOT%{_localstatedir}/cache/libvirt/

I'd removed all these rules a while ago, in favour of adding a rule to
the bottom ofo src/Makefile.am, so everyone installing libvirt gets the
right directories, instead of just RPM users

We should just need to add the 'cache' option to the Makefile.am too

>  
>  %if %{with_qemu}
>  # We don't want to install /etc/libvirt/qemu/networks in the main %files list
> @@ -422,6 +429,7 @@
>  %dir %{_localstatedir}/lib/libvirt/
>  %dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/images/
>  %dir %attr(0700, root, root) %{_localstatedir}/lib/libvirt/boot/
> +%dir %attr(0700, root, root) %{_localstatedir}/cache/libvirt/
>  
>  %if %{with_qemu}
>  %dir %{_localstatedir}/run/libvirt/qemu/

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]