Re: [libvirt] PATCH: Add a new error code for invalid operations

[Daniel Veillard <veillard redhat com>]

On Wed, Apr 29, 2009 at 03:32:02PM +0100, Daniel P. Berrange wrote:
> A number of operations are only valid when the corresponding object is in
> a particular state. eg,  you can only suspend a domain, if it is currently
> running. We don't have a very consistent way of reporting this problem 
> across drivers, so this patch introduces a new error code for this situation
> called  VIR_ERR_INVALID_OPERATION. This code is intended to be used if the
> operation is supported, but not applicable for the object at this time.
> It updates the Xen and QEMU drivers to use this error code.

  yes, makes sense, and patch looks fine, ACK

  thanks,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/