Re: [libvirt] [PATCH 1/1] Changes in version detection and moving a global variable in the global struct

[Pritesh Kothari <Pritesh Kothari Sun COM>]

On Thursday 30 April 2009 14:26:06 Daniel P. Berrange wrote:
> On Wed, Apr 29, 2009 at 01:14:05PM +0200, Pritesh Kothari wrote:
> > Hi All,
> >
> > PATCH 1/1: contains changes in version detection and moving a global
> > variable in the global struct, so that no more global vairables exists.
> >
> > +        if (uVersion >= 2001052 && uVersion < 2002051) {
> > +            DEBUG0("VirtualBox API version: 2.2");
> > +            driver        = &vbox22Driver;
> > +        } else if (uVersion >= 2002051 && uVersion < 2005051) {
> > +            DEBUG0("VirtualBox API version: 2.5");
> > +            driver        = &vbox25Driver;
> > +        } else {
> > +            DEBUG0("Unsupport VirtualBox API version");
> > +        }
>
> This bit seems to cause a link error for the driver, because nothing
> is defined the vbox25Driver symbol. I guess you have another patch
> pending to add vbox_V2_5.c  ?
>
> I just #if 0'd the 'else if' block to make it link

Thanks for #if0'ing it, sorry forgot it.
yes i have a patch for 2.5 but much of work is still underway due to the 
recent added functionality in VirtualBox, post it soon once it is stable 
enough.

Regards,
Pritesh