[libvirt] [PATCH] unify popen/fopen qemu wrappers

[Paolo Bonzini]

On 08/13/2009 01:18 PM, Daniel Veillard wrote:
> On Tue, Aug 11, 2009 at 06:30:36PM +0200, Paolo Bonzini wrote:
>> While reading Chris's code for fd migration I noticed the duplication
>> between QEMUFilePopen and QEMUFileStdio.  This fixes it, and makes
>> qemu_fopen more similar qemu_fdopen.
>
>    Looks fine to me, but what led to the initial duplication ?

Of course, this patch was sent to the wrong list, but besides that it 
looks just like an historical artifact.  The qemu_fopen interface was 
the original one and dates back to even before QEMUFile grew function 
pointers for get/put/close operations.  qemu_popen probably did not 
reuse the struct because it could not reuse the function pointers.

Paolo