Re: [libvirt] [PATCH] Allow no <source> for bridge interfaces

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Feb 02, 2009 at 07:01:50AM -0800, john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1233586907 28800
> # Node ID 68087e3caf39c74797720bde71a8df524ec036c8
> # Parent  aa50ca252e1419f30eb0e16204b48db42d92c785
> Allow no <source> for bridge interfaces
> 
> Historically, it was allowed to specify a bridge interface without a
> specific bridge source, in which case xend would choose one. Keep
> compatible with this behaviour.
> 
> Signed-off-by: John Levon <john levon sun com>

ACK in principle, but this will allow the QEMU, OpenVZ & Xen XM drivers
to potentially de-reference NULL when using the resulting parsed config
since they assume that brname is compulsory for type=bridge.

Dainel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|