Re: [libvirt] [PATCH] Allow off-line removal of devices via xend

[Cole Robinson <crobinso redhat com>]

john levon sun com wrote:
> # HG changeset patch
> # User john levon sun com
> # Date 1233765613 28800
> # Node ID bda41ea0cbbdea409447686c30b7afb10b9cae85
> # Parent  e6b17082b9b9440ce14ad76bd2f4c003ae2404db
> Allow off-line removal of devices via xend
> 
> We must avoid xenstore if the domain isn't running. For disks, this
> works in all xend versions; for NICs, however, this requires a change in
> netif.py to allow matching by MAC address. Preferring the device ID but
> falling back to the device ref works best with all versions of xend.
> 

No fault of this patch, but this makes me ask the question: what exactly
are attachDevice and detachDevice supposed to do?

In the qemu driver, it is entirely hotplug/hotunplug, and deliberately
fails on an inactive domain. This patch seems to add offline support
akin to 'remove disk device from xml and redefine' (or maybe it's always
attempted that in the xen driver?).

The documentation in libvirt.c is pretty ambiguous, so it would be nice
if we could clarify this.

Thanks,
Cole