Re: [libvirt] [PATCH 2/5] Add virNodeDeviceAttach()/ReAttach()/Reset() APIs

[Mark McLoughlin <markmc redhat com>]

On Wed, 2009-02-25 at 19:42 +0000, Daniel P. Berrange wrote:
> > > I think the attach/detach functions should be in the nodedev
> > > driver too, because they're not really part of the HV functionality.
> > > On modern Linux kernels, both Xen & KVM (and any other users) have 
> > > the same pci-stub.ko code for managed driver binding. On older Xen
> > > kernels, there is the functionally equivalent pci-back.ko.
> > 
> > Sure, but the logic to choose between pci-stub vs. pci-back is HV
> > specific, right?
> 
> No, its really kernel version depedant. On old Xen kernels it is always 
> pci-back. On mainline KVM / pv_ops Xen kernels, it'll always be pci-stub
> There's no need for Xen's pci-back, now the generic pci-stub exists.

Okay, that does makes some sense.

Sorry I didn't do the re-factoring in the set I just posted.

Cheers,
Mark.