Re: [libvirt] [PATCH]: Fix non-live migration failure

[Daniel Veillard <veillard redhat com>]

On Fri, Feb 27, 2009 at 01:12:40PM +0100, Chris Lalancette wrote:
> There is a logic error in the Qemu driver when doing a non-live migrate.
> During a non-live migrate, on the source host during the Perform step, we
> pause the domain; however, if there was ever a failure, we were forgetting
> to unpause the domain, meaning that the domain was paused forever.  Add a
> flag to tell us when we should unpause the domain after a failure.
> 
> Also, as pointed out by DV, we were unnecessarily using a snprintf to a
> buffer to execute qemu monitor commands, when we could get away with
> just sending a static string.  Fix that as well.

  Oh right I had missed the leak :-)
Looks fine to me now,

Daniel


-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/