[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]: pass flags to all virDomain*DefParse* functions



On Fri, Dec 26, 2008 at 02:19:06PM +0100, Guido G?nther wrote:
> > > > > > by honoring the VIR_DOMAIN_XML_INACTIVE flag.
> > > > > O.k. to commit this part as a start so you can readily use it vor lxc?
> > > > 
> > > > ACK, assuming 'make check' still passes.
> > > It does here, sure. Patch Applied now. I've added the flag to the
> > > functions currently needed for qemu but if nobody objects I'd like to
> > > add them to:
> > > 
> > > virDomainDeviceDefParse
> > > virDomainDefParseString
> > > virDomainHostdevSubsysUsbDefParseXML
> > > virDomainDiskDefParseXML
> > > virDomainFSDefParseXML
> > > virDomainNetDefParseXML
> > > virDomainInputDefParseXML
> > > virDomainSoundDefParseXML
> > > virDomainHostdevDefParseXML
> > > virDomainChrDefParseXML
> > 
> Attached patch adds a flag parameter to the above functions and passes
> VIR_DOMAIN_XML_INACTIVE from the upper levels. I see two advantages in
> this:
> 
> * symmetric interfaces to the XML parsing functions (why has
>   virDomainDefParseFile a flags argument while virDomainDefParseString
>   hasn't)
> * other drivers can use this very easily (IIRC lxc has some use for it)
> 
> otherwise there's not too much gain so I'm a bit undecided if this is
> actually necessary.

ACK

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]