[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virConnectGetHostname: return a fully qualified hostname



On Thu, Dec 11, 2008 at 09:24:27PM +0000, David Lutterkort wrote:
> Here is a revised patch that addresses all the comments from Jim and
> Dan:
> 
>       * Use getaddrinfo instead of gethostbyname
>       * Terminate hostname explicitly with NUL_TERMINATE
>       * Do not repeat constant HOST_NAME_MAX+1
>       * Use tabs, not spaces in libvirt_sym.version.in


  Better late than never, I applied that cleanup, it needed just a bit
of adjustment to use src/libvirt_private.syms instead of libvirt_sym.version

   thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]