Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change

[Daniel Veillard <veillard redhat com>]

On Mon, Jan 12, 2009 at 11:17:52AM +0000, Mark McLoughlin wrote:
> On Mon, 2009-01-12 at 11:30 +0100, Daniel Veillard wrote:
> 
> > +      For PCI devices the element carries 3 attributes allowing to designate
> > +      the device as can be found with the <code>lspci</code> command, the
> > +      <code>bus</code> attribute allows the hexadecimal values 0 to ff, the
> > +      <code>slot</code> attribute allows the hexadecimal values 0 to 1f, and
> > +      the <code>function</code> attribute allows the hexadecimal values 0 to
> > +      7.</dd></dl>
> 
> Looks good, but probably want to recommend "virsh nodedev-list" rather
> than lspci?

  Okay I commited the docs with a reference to both, as I think this
covers slight different users. I also documented the domain optional
argument and removed the code to avoid saving it,

  thanks for the fast review :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/