Re: [libvirt] adding tests....

[Daniel Berrange <berrange redhat com>]

On Mon, Jan 12, 2009 at 01:28:41PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> >> +    if (remote_config_file == NULL) {
> >> +	static const char *default_config_file
> >> +	  = SYSCONF_DIR "/libvirt/libvirtd.conf";
> >> +	remote_config_file =
> >> +	  (access(default_config_file, X_OK) == 0
> >> +	   ? default_config_file
> >> +	   : "/dev/null");
> >> +    }

That should be R_OK, not X_OK - the config files aren't
marked executable, so this will never load the config.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|