Re: [libvirt] [PATCH] Introduce virt-console

["Richard W.M. Jones" <rjones redhat com>]

On Wed, Jan 14, 2009 at 07:21:10AM -0800, john levon sun com wrote:
> +#ifdef __sun

I'm really unhappy about adding #ifdef __sun everywhere in this file.
Configure should detect the features that are needed / available /
missing, and the #ifdefs should go on the result of that.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora