[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Introduce virt-console



On Thu, Jan 15, 2009 at 11:47:13AM +0000, Richard W.M. Jones wrote:

> On Wed, Jan 14, 2009 at 07:21:10AM -0800, john levon sun com wrote:
> > +#ifdef __sun
> 
> I'm really unhappy about adding #ifdef __sun everywhere in this file.
> Configure should detect the features that are needed / available /
> missing, and the #ifdefs should go on the result of that.

This is Solaris stuff that doesn't and won't exist anywhere else. It
would just be moving the #ifdef __sun into configure.in - I can't 
think what advantage you would be expecting from this, or indeed how to
even test the need to do the I_PUSHes.

regards
john


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]