Re: [libvirt] PATCH: 7/25: Minor windows fix to remote driver

[Jim Meyering <jim meyering net>]

"Daniel P. Berrange" <berrange redhat com> wrote:
> Minor problem in the remote driver when lacking support for
> virExec(), we report an error and then carry on executing
> anyway. Of course we get a EINVAL error later when we try to
> write() on a FD of -1. Trivial fix
>
>  remote_internal.c |    1 +
>  1 file changed, 1 insertion(+)
>
> Daniel
>
> diff --git a/src/remote_internal.c b/src/remote_internal.c
> --- a/src/remote_internal.c
> +++ b/src/remote_internal.c
> @@ -690,6 +690,7 @@ doRemoteOpen (virConnectPtr conn,
>      case trans_ext:
>          error (conn, VIR_ERR_INVALID_ARG,
>                 _("transport methods unix, ssh and ext are not supported under Windows"));
> +        goto failed;

ACK. an obvious improvement.