[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Introduce virt-console



On Thu, Jan 15, 2009 at 02:05:14PM +0000, Richard W.M. Jones wrote:

> > No - if this ever happens, it will not break pty-using code. Again, what
> > test are you thinking of to detect that the pty code is STREAMS based?
> > I'm not being obstructive here - I genuinely cannot conceive what such a
> > test would look like.
> 
> I think something as simple as:
> 
>   AC_CHECK_FUNCS([isastream])
> 
> is sufficient to check whether the libc claims to support STREAMS.

That wasn't what I asked for.

> If it turns out that someone has installed a buggy STREAMS
> implementation, we can make the check more fine-grained later.

Again, it's NOT buggy for isastream to exist, and pty's to be
non-STREAMS.

My way:

 - definitely not buggy, less code

Your way:

 - possibly buggy, more code

What platform are you expecting this extra code to help? It's not the
BSDs, Mac OS X, Solaris, Linux, or Windows. I'll buy you tea at the Ritz
if someone ports libvirt to UnixWare :)

regards,
john


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]