Re: [libvirt] PATCH: 5/25: Locking in remote driver

["Richard W.M. Jones" <rjones redhat com>]

On Tue, Jan 13, 2009 at 05:40:18PM +0000, Daniel P. Berrange wrote:
> Adds locking in the remote driver. This obtains the lock on every single
> API method. This is quite poor, not giving any parallelism - that will
> be added in 2 patch's time, when we drop the lock while waiting on I/O
> 
>  remote_internal.c |  523 +++++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 481 insertions(+), 42 deletions(-)

I worry about remoteNetworkOpen, but the code there already is
tortuous enough.  remoteDevMonOpen is even more horrible, but it
appears correct.  Guarded +1.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my OCaml programming blog: http://camltastic.blogspot.com/
Fedora now supports 68 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora