Re: [libvirt] PATCH: 7/25: Minor windows fix to remote driver

["Richard W.M. Jones" <rjones redhat com>]

On Tue, Jan 13, 2009 at 05:41:15PM +0000, Daniel P. Berrange wrote:
> Minor problem in the remote driver when lacking support for
> virExec(), we report an error and then carry on executing
> anyway. Of course we get a EINVAL error later when we try to
> write() on a FD of -1. Trivial fix
> 
>  remote_internal.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Daniel
> 
> diff --git a/src/remote_internal.c b/src/remote_internal.c
> --- a/src/remote_internal.c
> +++ b/src/remote_internal.c
> @@ -690,6 +690,7 @@ doRemoteOpen (virConnectPtr conn,
>      case trans_ext:
>          error (conn, VIR_ERR_INVALID_ARG,
>                 _("transport methods unix, ssh and ext are not supported under Windows"));
> +        goto failed;
>  
>  #endif /* WIN32 */

+1, obvious.

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/