[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 10/25: Remove use of strerror()



On Tue, Jan 13, 2009 at 05:42:41PM +0000, Daniel P. Berrange wrote:
> The strerror() method is not guarenteed to be re-entrant, which is
> rather a pain because the strerror_r() method is rather unpleasant
> to use. In addition our code is quite inconsistent about using 
> VIR_ERR_SYSTEM_ERROR vs VIR_ERR_INTERNAL_ERROR for problems which
> have an 'errno' avilable. Likewise we're not very consistent about
> OOM reporting error codes
> 
> This patch thus introduces two convenient functions for reporting a
> system error and OOM error.
> 
>  virReportSystemError(conn, theerrno, fmt,...)
>  virReportOOMError(conn)

Yes, a very welcome change.  I've looked through the patch briefly and
it looks good, and hoping gcc would pick up any gross argument
mismatches.  So +1.

> diff --git a/autobuild.sh b/autobuild.sh
> --- a/autobuild.sh
> +++ b/autobuild.sh
> @@ -65,6 +65,7 @@ if [ -x /usr/bin/i686-pc-mingw32-gcc ]; 
>      --build=$(uname -m)-pc-linux \
>      --host=i686-pc-mingw32 \
>      --prefix="$AUTOBUILD_INSTALL_ROOT/i686-pc-mingw32/sys-root/mingw" \
> +    --enable-compile-warnings=error \
>      --without-sasl \
>      --without-avahi \
>      --without-polkit \

Intended?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]