[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
[libvirt] [PATCH] Fix vm define error with back compat console device
- From: Cole Robinson <crobinso redhat com>
- To: Libvirt <libvir-list redhat com>
- Subject: [libvirt] [PATCH] Fix vm define error with back compat console device
- Date: Thu, 15 Jan 2009 12:41:28 -0500
If you define a domain with serial devs > 0 && parallel devs >= serial
devs, libvirtd segfaults when trying to set up the back compat console
device. We were using a previous loop counter where we shouldn't. The
attached patch fixes this.
Thanks,
Cole
diff --git a/src/domain_conf.c b/src/domain_conf.c
index 8bb51f7..890afe0 100644
--- a/src/domain_conf.c
+++ b/src/domain_conf.c
@@ -3320,8 +3320,9 @@ char *virDomainDefFormat(virConnectPtr conn,
if (virDomainChrDefFormat(conn, &buf, def->console, "console") < 0)
goto cleanup;
} else if (def->nserials != 0) {
- /* ..else for legacy compat duplicate the serial device as a console */
- if (virDomainChrDefFormat(conn, &buf, def->serials[n], "console") < 0)
+ /* ..else for legacy compat duplicate the first serial device as a
+ * console */
+ if (virDomainChrDefFormat(conn, &buf, def->serials[0], "console") < 0)
goto cleanup;
}
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]