[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 17/25: Concurrent client dispatch in libvirtd



On Tue, Jan 13, 2009 at 09:51:00PM +0000, Daniel P. Berrange wrote:
[...]

>From a "peephole" view of the patch, it looks sane enough, and I think
we should commit it and debug any fallout later.  One tiny comment:

> +struct qemud_client_message;
> +
> +struct qemud_client_message {
> +    char buffer [REMOTE_MESSAGE_MAX + REMOTE_MESSAGE_HEADER_XDR_LEN];
> +    unsigned int bufferLength;
> +    unsigned int bufferOffset;
> +
> +    int async : 1;
> +
> +    struct qemud_client_message *next;
> +};

(1) You don't need to predeclare the struct.  (2) This means the
struct is always the same size as the maximum-sized message.
Shouldn't we malloc the buffer?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]