[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/7 RFC] RHEL-5 support, and a few preparatory fixes



On Tue, Dec 23, 2008 at 04:04:21PM +0100, Markus Armbruster wrote:
> This patch series attempts to make libvirt just work on RHEL-5.  Right
> now it doesn't, mostly because libvirt relies on version number checks
> in a couple of places, and RHEL-5's version numbers aren't the whole
> truth due to various backports of later stuff.

  Based on the earlier discussion, I think we should apply those
  patches:

> The first two patches are plain bug fixes:
> 
>     [PATCH 1/7] Fix network device inconsistency between xm and sxpr
>     [PATCH 2/7] Fix graphics configuration inconsistency between xm and sxpr

  because those are just plain bug fixes

> The next three add a few special cases for RHEL-5:
> 
>     [PATCH 3/7] New configure option --with-rhel5-api
>     [PATCH 4/7] Fix HVM network device configuration for RHEL-5
>     [PATCH 5/7] Fix PVFB device configuration for RHEL-5
>     [PATCH 6/7] Enable NUMA support for RHEL-5

  because they are really no-ops if one didn't configured
--with-rhel5-api (assuming the slight change I pointed out in 4/7)

> The last one drops a counter-productive error check:
> 
>     [PATCH 7/7] Don't treat missing topology information as error

  That's really a cleanup IMHO,

> See the patches for more detailed descriptions.
> 
> I'm not proposing this for immediate commit, as I'm still testing.
> But I'd appreciate review: is this the right way to do it?

  That looks fine to me, the only point is whether the configure option
should be added, I guess it benefits more than just the RHEL users
but also CentOS users so those should be commited. I plan to do this
today but I just want to do a bit of testing on it first and check my
4/7 suggested change.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]