Re: [libvirt] [PATCH 0/7 RFC] RHEL-5 support, and a few preparatory fixes

["Daniel P. Berrange" <berrange redhat com>]

On Mon, Jan 19, 2009 at 09:20:57PM +0100, Daniel Veillard wrote:
> On Mon, Jan 19, 2009 at 03:52:02PM +0100, Daniel Veillard wrote:
> > On Tue, Dec 23, 2008 at 04:04:21PM +0100, Markus Armbruster wrote:
> > > This patch series attempts to make libvirt just work on RHEL-5.  Right
> > > now it doesn't, mostly because libvirt relies on version number checks
> > > in a couple of places, and RHEL-5's version numbers aren't the whole
> > > truth due to various backports of later stuff.
> > 
> >   Based on the earlier discussion, I think we should apply those
> >   patches:
> 
>   Done, of course the regression tests now fail if the rhel5 specific
> configure option is turned on, I guess that's normal, maybe the
> SEXP<->XML conversion tests need to be switched off in that case, or
> we should generate alternate version when running in that case.

I'll take a look - IIRC it should be reasonably easy for me to make 
the tests work even when the rhel5-xen option is turned on. We definitely
want to validate that this option is actually doing what we intend, so
prefer not to totally disable the tests in question

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|