[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: 16/25: Fix GNULIB warnings on Mingw



On Mon, Jan 19, 2009 at 07:41:18PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> > The GNULIB Makefile.am doesn't set any particular compiler warning
> > flags in the belief that upstream GNULIB developers sort out all
> > warnings before committing their code. This is reasonable for builds
> > on mainstream Linux platforms, but MinGW builds of GNULIB don't
> > have nearly the same level of testing. So This patch adds the libvirt
> > $(WARN_CFLAGS) to the gnulib Makefile.am and then fixes the problems
> > this showed up. Nothing of consequence really. Leave it upto gnulib
> > developers whether its worth fixing these.
> >
> >  Makefile.am    |    2
> 
> The following or equivalent have all been applied in gnulib.

Ok, since the later patch will run  bootstrap again, I'll pull these in
at that point.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]