[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Quieten virsh schedinfo for shutoff domain



On Thu, Jan 22, 2009 at 05:49:12PM -0800, john levon sun com wrote:
> +    /*
> +     * If it's not running, we can't help.
> +     */
> +    if (domain->id < 0)
> +        return NULL;

NACK.  Unfortunately you shouldn't return from a function without
setting an error (and you have to set an error exactly once otherwise
earlier errors get overwritten).

Perhaps if you want to silence the error, you can silence it in the
calling code, eg. in virsh, by matching on the appropriate virterror
fields, eg error->code ?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]