Re: [libvirt] [PATCH] kvm/virtio: Set IFF_VNET_HDR when setting up tap fds

[Mark McLoughlin <markmc redhat com>]

On Tue, 2009-01-27 at 10:05 +0000, Daniel P. Berrange wrote:
> On Mon, Jan 26, 2009 at 10:39:25AM +0000, Mark McLoughlin wrote:

> > It's nearly five months since kvm-74 - the first KVM release with this
> > feature - was released. Up until now, we've not added libvirt support
> > because there is no clean way to detect support for this in QEMU at
> > runtime. A brief attempt to add a "info capabilities" monitor command
> > to QEMU floundered. Perfect is the enemy of good enough. Probing the
> > KVM version will suffice for now.
> 
> ACK to the approach taken here. I've had todo the same version based
> check for the migration features, since that has broken compatability
> and is also totally undocumented in the command line help output.

Thanks, committed now.

Cheers,
Mark.