[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Fix save/restore for new KVM



On Thu, Jan 29, 2009 at 03:16:11PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> > This is a repost of the patch from:
> >
> > http://www.redhat.com/archives/libvir-list/2009-January/msg00583.html
> >
> > updated to take account of the changes commited since I first posted it.
> 
> Thanks.
> 
> The fix looks right.
> Glad you added those tests.
> It's nice to have all of those constants documented, too.
> ACK.
> 
> Since DO_TEST is now a trivial specialization of
> the new DO_TEST_MIGRATE, you can simplify.
> Plus, I added a "const".

I didn't like having DO_TEST before the thing it used, so I
swapped the order, and also renamed DO_TEST_MIGRATE to DO_TEST_FULL.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]