Re: [libvirt] PATCH: Fix passing of ifname to QEMU

[Daniel Veillard <veillard redhat com>]

On Fri, Jan 30, 2009 at 01:08:54PM +0000, Daniel P. Berrange wrote:
> When using the type='ethernet'  network device configuration for a guest
> we pass a script, and optional interface name to QEMU. If ifname is 
> omitted, then QEMU allocates one itself. The problem was we were passing
> an ifname of '(null)' by mistake. This patch corrects that problem and
> adds a test for it.

  Okay, we would have caught it before if  the libc segfaulted in such
a situation. +1 to the patch . I wonder if there is a way to avoid glibc
current behaviour when doing regression tests, waiting for solaris
testing is not a good way to catch those :-\

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/