Re: [libvirt] Re: [PATCH 0/3] A small example program

["Daniel P. Berrange" <berrange redhat com>]

On Fri, Jan 30, 2009 at 03:54:17PM +0100, Jim Meyering wrote:
> "Daniel P. Berrange" <berrange redhat com> wrote:
> >
> > Hmm, it should use the native arch - virExtractVersionInfo needs
> > fixing to call uname, and extract the native arch. Hardcoding
> > i386 was sufficient, when we mandated that 'qemu' was always
> > present, but now we allow either qemu or KVM, so we need to
> > always use native.  NB, i3/4/586 should be mapped to i686.
> 
> I see you already had to do that once.

Oh yes, forgot about that.

> 
> From 0131996b3cd819624259d6adcc5d968d6a0210b1 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering redhat com>
> Date: Fri, 30 Jan 2009 15:41:39 +0100
> Subject: [PATCH] fix qemud version reporting when qemu is not installed
> 
> * src/qemu_conf.c (uname_normalize): New function, factored out of...
> (qemudBuildCommandLine): ...here.  Use the new function.
> (qemudExtractVersion): Use it here, rather than hard-coding "i686".

ACK to this.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|