[libvirt] Migration API broken for xenmigr://

[Daniel P. Berrange]

On Fri, Jan 30, 2009 at 11:04:12AM -0500, John Levon wrote:
> On Fri, Jan 30, 2009 at 03:41:04PM +0000, Daniel P. Berrange wrote:
> 
> > > This is obviously impossible for xenmigr:///. As a result, virsh migrate
> > > always returns  an error code:
> > 
> > I'm not sure I understand why this is impossible ?
> 
> I thought the purpose of xenmigr:/// was to allow live migration the
> traditional way without needing a remotely accessible libvirtd. At
> least, that's how we're using it. If it's the intention of libvirt that
> you must always have a listening remote API, then we'll have to work out
> a private fix for our tree.
> 
> > > # virsh migrate --live domu-220 xen:/// interpol
> > > 18:44:40.974: error : Domain not found: xenUnifiedDomainLookupByName
> > > libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName
> > > libvir: Xen error : Domain not found: xenUnifiedDomainLookupByName
> > > 
> > > thewhip:xend # echo $?
> > > 1
> > > 
> > > Since virDomainLookupByName() returns NULL. I will request again, can I
> > > remove the 'error' code from xenUnifiedDomainLookupByName?
> > 
> > I'm not sure why it returns NULL there ?!?!
> 
> xen:/// (the local source host) no longer has the domain, since it moved
> to interpol.

Yeah, so you've passed invalid data to the migrate call by giving
it two connections which both point to the source host. Would
should really add a sanity check to try & detect that mistake.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|