[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [libvirt] [PATCH 04/14] Factor qemuBuildHostNetStr() out from qemuBuildCommandLine()
- From: Daniel Veillard <veillard redhat com>
- To: Mark McLoughlin <markmc redhat com>
- Cc: libvirt-list redhat com
- Subject: Re: [libvirt] [PATCH 04/14] Factor qemuBuildHostNetStr() out from qemuBuildCommandLine()
- Date: Mon, 20 Jul 2009 14:33:45 +0200
On Mon, Jul 20, 2009 at 12:51:14PM +0100, Mark McLoughlin wrote:
> Re-factor this code so that it can be used for NIC hotplug
> too. The awkward prefix and type_sep arguments are needed to
> allow us to do "host_net_add tap vlan=..."
>
> * src/qemu_conf.c: factor the net backend string formatting
> code into its own function
> ---
> src/qemu_conf.c | 233 +++++++++++++++++++++++++++++--------------------------
> 1 files changed, 122 insertions(+), 111 deletions(-)
It looks like it will be nicer, yes though patch output is a bit
confusing :-) ACK
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel veillard com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]