Re: [libvirt] [PATCH 6/6] Add canonical machine name to capabilities output

[Daniel Veillard <veillard redhat com>]

On Mon, Jul 27, 2009 at 03:30:01PM +0100, Mark McLoughlin wrote:
> On Mon, 2009-07-27 at 15:45 +0200, Daniel Veillard wrote:
> > On Thu, Jul 23, 2009 at 06:34:44PM +0100, Mark McLoughlin wrote:
> > > e.g. <machine canonical='pc'>pc-0.11</machine>
> > > 
> > > * src/capabilities.c: output the canonical machine names in the
> > >   capabilities output, if available
> > 
> >   ACK, but this is missing the rng extention and the documentation for
> >   the extension,
> 
> Right, patch below to add it to the rng, but the capabilities docs needs
> a good bit of work before adding docs on this little piece wouldn't seem
> so much out of date - e.g. they're mostly about xen and not very
> specific.

  okay

> diff --git a/docs/schemas/capability.rng b/docs/schemas/capability.rng
> index f085e55..775bbdb 100644
> --- a/docs/schemas/capability.rng
> +++ b/docs/schemas/capability.rng
> @@ -196,6 +196,11 @@
>  
>    <define name='machine'>
>      <element name='machine'>
> +      <optional>
> +        <attribute name='canonical'>
> +          <text/>
> +        </attribute>
> +      </optional>
>        <text/>
>      </element>
>    </define>
> 

 I suppose QEmu doesn't define a syntax for allowed machine names :-)

 ACK

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/