Re: [libvirt] PATCH: Misc user mode linux startup bugs

[Daniel Veillard <veillard redhat com>]

On Tue, Jun 02, 2009 at 10:50:56AM +0100, Daniel P. Berrange wrote:
> There's a number of annoying bugs in the user mode linux driver startup
> code. This patch fixes lots of them. We failed to check umlMonitorCommand
> for error, leading to a NULL de-reference due to another bug in that
> function. This patch also checks if 'res' is NULL before de-referenceing
> it, just in case.  In the code for handling inotify delete events, we
> duplicated alot of the umlShutdownVMDaemon code, but forgot to close
> the monitor. This patches makes it just call umlShutdownVMDaemon directly.
> In one place where we spin in a usleep loop, we forgot to increment our
> retries counter, making it spin forever. Finally, switch to virKillProcess

  nice one :-)

> and make the latter also avoids pid==1, since I can't  imagine a time 
> where we'd ever want to kill 'init' :-)

  Even better


  looks fine, ACK :-)

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/