Re: [libvirt] PATCH: Support networking in User Mode Linux driver

[Daniel Veillard <veillard redhat com>]

On Tue, Jun 02, 2009 at 10:52:59AM +0100, Daniel P. Berrange wrote:
> This patch adds support for bridge, virtual network, multicast and user-mode
> networking  in the User Mode Linux driver. You can't pass an open TAP device
> file descriptor to UML, so we also extend the bridge.c file to supporting
> creation & deletion of persistent TAP devices.

  Looks fine,

> +            if (!tapfd &&
> +                (errno = ioctl(fd, TUNSETPERSIST, 1)))
> +                goto error;

  I was just a bit worried about this new ioctl value, but it seems
  defined even on old kernels.

 ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/