Re: [libvirt] [PATCH] Don't disable all logging with --disable-debug

["Daniel P. Berrange" <berrange redhat com>]

On Thu, Jun 25, 2009 at 04:13:28PM -0400, Amy Griffis wrote:
> This patch changes the automake conditional for debugging to
> disable only the debug output, not the entire logging module.
> Since the logging symbols are always visible now, I moved them to
> libvirt_private.syms and got rid of libvirt_debug.syms. I noticed
> that debugFlag wasn't being used anymore, so I removed that too.
> 
> There was some code in __virExec where if you called with NULLs
> for childout and childerr, it would conditionally set the fds to
> either -1 or the /dev/null fd depending on ENABLE_DEBUG. I'm not
> sure why the difference, but it seemed safe to remove the entire
> conditional section since either setting is effectively treated
> the same way in the following code.
> 
> Signed-off-by: Amy Griffis <amy griffis hp com>

ACK

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|