[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't log qemu monitor output from blockStats



On Mon, Mar 02, 2009 at 01:27:33PM -0500, Cole Robinson wrote:
> The attached patch changes the qemu driver blockStats command to not log
> qemu monitor output. virt-manager offers an option to continually poll
> VM disk stats, and if the app is left running for a while with many VMs,
> this can make the logs huge, for little benefit (a user reported 100 MB
> with virt-manager left running overnight).
> 
> The output from the command is still printed with a DEBUG call, so the
> info isn't completely lost.

IMHO we should just disable all this logging rather than adding a second
method. If we need to debug the arg/replies, then libvirtd now have proper
logging we can turn on/off as needed, without having to dup this via the
per-VM logfile. So, just rely on VIR_DEBUG() macros instead.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]