[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] PATCH: Always reset PCI devices



On Mon, Mar 02, 2009 at 06:27:17PM +0000, Daniel P. Berrange wrote:
> Mark's patches added a attribute  managed='yes|no' for PCI <hostdev> 
> configuration. This allows the caller app to indicate  who is responsible
> for attaching/detaching the PCI device from the host drivers. When using
> managed=yes, libvirt does it, while using managed=no, the someone else
> should do it - typically blacklist the devices in /etc/modprobe.conf
> 
> Before launching a guest though the devices need to be reset. Mark made
> the reset operation conditional on managed=yes, which was not what I
> had intended. libvirtd should always reset the devices so they are in
> a sane state before booting, regardless of who manages the host driver
> binding. The forthcoming PCI passthrough suppor in the Xen driver will
> work in this way - we'll only support managed=no, but XenD will still
> always do the reset of devices
> 
> I also add a comment to remind us that we should add validation that
> the PCI device is not still in use in the non-managed case.

  ACK, but adding in the comment a hint on how to do that validation
would be nice.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]