[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]
Re: [libvirt] PATCH: Don't reset / detach host PCI devices in test scripts !
- From: "Daniel P. Berrange" <berrange redhat com>
- To: Daniel Veillard <veillard redhat com>
- Cc: libvir-list redhat com
- Subject: Re: [libvirt] PATCH: Don't reset / detach host PCI devices in test scripts !
- Date: Tue, 3 Mar 2009 09:00:06 +0000
On Mon, Mar 02, 2009 at 09:56:04PM +0100, Daniel Veillard wrote:
> On Mon, Mar 02, 2009 at 08:51:01PM +0000, Daniel P. Berrange wrote:
> > The PCI passthrough patches made it so that qemudBuildCommandLine() would
> > actually try to detach your host devices & reset them. Most definitely not
> > what you want when running this via a test case!
> >
> > This patch moves the host device management out into a separate method,
> > so that qemudBuildCommandLine() doesn't do anything except safely build
> > the command line.
>
> Oops, ACK !
ok, committed this since it was breaking the test suite
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
[Date Prev][Date Next] [Thread Prev][Thread Next]
[Thread Index]
[Date Index]
[Author Index]